Closed AlexandruPascu closed 4 months ago
Working on it now but most of the tests are failing, if the parser is updated, especially the default cycler e.t.c, the tests need to be updated in lockstep.
Hi @AlexandruPascu Could you look over the tests, and do a bit of digging into the function defaults you’ve given. Some of the positional/default arguments are now None or Empty strings that get checked and crash out later. The command:
nox -s unit
Should pass without issue and until it does we cant merge these branches. I’ve pushed my initial work on it happy to chat on teams/zoom e.t.c...
Hello @PipGrylls! Thanks for having a look over everything! Can you please drop me a message over Teams with when you'd be available for a call tomorrow? I think it would be easier to understand
@PipGrylls could you please have a look at the Ubuntu tests? I think they are trying to run the example while the others not? Please let me know if there is smth I can do about that and have a look again at the code since now it's passing the tests :)
Description
Fixes #22 (issue) Fixes #14 (issue) Fixes #11 (issue) Fixes #9 (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist
$ python -m nox -s lint
$ python -m nox -s unit examples integration
$ python -m nox -s coverage
$ python -m nox -s sphinx
Further checks