search

paramm-team / pybamm-param

Parameter optimisation for PyBaMM.
BSD 3-Clause "New" or "Revised" License
38 stars 8 forks source link

Setup_cost_function for OCP balance does not work for cathode #14

Closed muhammedsogut closed 2 years ago

muhammedsogut commented 2 years ago

setup_cost_function() within pbparam.OCPBalance works for anode but there is an error for cathode. The test notebook is:

https://github.com/paramm-team/pybamm-param/blob/adding-test-notebooks/examples/notebooks/test_ocp.ipynb

brosaplanella commented 2 years ago

That is what we discussed in the meeting, right?

muhammedsogut commented 2 years ago

Yes, this isssue has been resolved now.