codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 60.00% and project coverage change: +0.05 :tada:
Comparison is base (
6a13329) 86.48% compared to head (75f8335) 86.53%.:exclamation: Current head 75f8335 differs from pull request most recent head a697e17. Consider uploading reports for the commit a697e17 to get more accurate results
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #40 +/- ## ========================================== + Coverage 86.48% 86.53% +0.05% ========================================== Files 12 12 Lines 259 260 +1 ========================================== + Hits 224 225 +1 Misses 35 35 ``` | [Impacted Files](https://app.codecov.io/gh/paramm-team/pybamm-param/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paramm-team) | Coverage Δ | | |---|---|---| | [pbparam/optimisation\_problems/data\_fit.py](https://app.codecov.io/gh/paramm-team/pybamm-param/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paramm-team#diff-cGJwYXJhbS9vcHRpbWlzYXRpb25fcHJvYmxlbXMvZGF0YV9maXQucHk=) | `56.00% <33.33%> (+0.59%)` | :arrow_up: | | [pbparam/optimisers/scipy\_minimize.py](https://app.codecov.io/gh/paramm-team/pybamm-param/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paramm-team#diff-cGJwYXJhbS9vcHRpbWlzZXJzL3NjaXB5X21pbmltaXplLnB5) | `96.00% <100.00%> (ø)` | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Description
Allow to pass
simulation_optionstoDataFitso thecalc_esohissue can be circumvented.