42

[PipGrylls]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #42

Refactor

This is a refactor to bring rules and conformity to the optimisation problems.

• [ ] New feature (non-breaking change which adds functionality)
• [ ] Optimization (back-end change that speeds up the code)
• [X] Bug fix (non-breaking change which fixes an issue)

Key checklist:

• [x] No style issues: $ flake8
• [x] All tests pass: $ python run-tests.py --unit
• [x] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• [x] Code is commented, particularly in hard-to-understand areas
• [x] Tests added that prove fix is effective or that feature works

[codecov[bot]]

Codecov Report

Patch coverage: 67.59% and project coverage change: -10.71% :warning:

Comparison is base (eb82cbf) 93.11% compared to head (a939684) 82.41%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #49 +/- ## ============================================ - Coverage 93.11% 82.41% -10.71% ============================================ Files 12 13 +1 Lines 276 307 +31 ============================================ - Hits 257 253 -4 - Misses 19 54 +35 ``` | [Files Changed](https://app.codecov.io/gh/paramm-team/pybamm-param/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paramm-team) | Coverage Δ | | |---|---|---| | [pbparam/optimisation\_problems/gitt.py](https://app.codecov.io/gh/paramm-team/pybamm-param/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paramm-team#diff-cGJwYXJhbS9vcHRpbWlzYXRpb25fcHJvYmxlbXMvZ2l0dC5weQ==) | `0.00% <0.00%> (ø)` | | | [...optimisation\_problems/base\_optimisation\_problem.py](https://app.codecov.io/gh/paramm-team/pybamm-param/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paramm-team#diff-cGJwYXJhbS9vcHRpbWlzYXRpb25fcHJvYmxlbXMvYmFzZV9vcHRpbWlzYXRpb25fcHJvYmxlbS5weQ==) | `96.07% <94.87%> (-3.93%)` | :arrow_down: | | [pbparam/optimisation\_problems/OCP\_balance.py](https://app.codecov.io/gh/paramm-team/pybamm-param/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paramm-team#diff-cGJwYXJhbS9vcHRpbWlzYXRpb25fcHJvYmxlbXMvT0NQX2JhbGFuY2UucHk=) | `100.00% <100.00%> (ø)` | | | [pbparam/optimisation\_problems/data\_fit.py](https://app.codecov.io/gh/paramm-team/pybamm-param/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paramm-team#diff-cGJwYXJhbS9vcHRpbWlzYXRpb25fcHJvYmxlbXMvZGF0YV9maXQucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.