paramm-team / pybamm-param

Parameter optimisation for PyBaMM.
BSD 3-Clause "New" or "Revised" License
38 stars 8 forks source link

Add BasicGITT model #50

Closed brosaplanella closed 1 year ago

brosaplanella commented 1 year ago

Description

Add BasicGITT model so we can do some progress with GITT while I figure out how to implement it in PyBaMM.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

Key checklist:

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 95.52% and project coverage change: +4.36% :tada:

Comparison is base (425303d) 83.63% compared to head (04ecc98) 88.00%. Report is 34 commits behind head on develop.

:exclamation: Current head 04ecc98 differs from pull request most recent head df7f404. Consider uploading reports for the commit df7f404 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #50 +/- ## =========================================== + Coverage 83.63% 88.00% +4.36% =========================================== Files 13 15 +2 Lines 336 400 +64 =========================================== + Hits 281 352 +71 + Misses 55 48 -7 ``` | [Files Changed](https://app.codecov.io/gh/paramm-team/pybamm-param/pull/50?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paramm-team) | Coverage Δ | | |---|---|---| | [pbparam/optimisation\_problems/gitt.py](https://app.codecov.io/gh/paramm-team/pybamm-param/pull/50?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paramm-team#diff-cGJwYXJhbS9vcHRpbWlzYXRpb25fcHJvYmxlbXMvZ2l0dC5weQ==) | `21.21% <0.00%> (+21.21%)` | :arrow_up: | | [pbparam/\_\_init\_\_.py](https://app.codecov.io/gh/paramm-team/pybamm-param/pull/50?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paramm-team#diff-cGJwYXJhbS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [pbparam/models/basic\_gitt.py](https://app.codecov.io/gh/paramm-team/pybamm-param/pull/50?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paramm-team#diff-cGJwYXJhbS9tb2RlbHMvYmFzaWNfZ2l0dC5weQ==) | `100.00% <100.00%> (ø)` | | | [pbparam/models/weppner\_huggins.py](https://app.codecov.io/gh/paramm-team/pybamm-param/pull/50?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paramm-team#diff-cGJwYXJhbS9tb2RlbHMvd2VwcG5lcl9odWdnaW5zLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.