search

paramm-team / pybamm-param

Parameter optimisation for PyBaMM.
BSD 3-Clause "New" or "Revised" License
38 stars 8 forks source link

Refactor `OCPBalance` to use `pybamm.Simulation` as model #52

Open brosaplanella opened 1 year ago

brosaplanella commented 1 year ago

Currently OCPBalance does not use pybamm.Simulation which means many parts of the code are written in a hacky way. Reformat it to use a PyBaMM model so code can be refactored into BaseOptimisationProblem. This should make it easier to implement new features going forward, e.g. #38.

brosaplanella commented 9 months ago

Definition: