paramm-team / pybamm-param

Parameter optimisation for PyBaMM.
BSD 3-Clause "New" or "Revised" License
38 stars 8 forks source link

Implement simple EIS model as PyBaMM simulation #66

Open brosaplanella opened 11 months ago

brosaplanella commented 11 months ago

Write a EIS model that can be wrapped as a PyBaMM simulation for a proof of concept.

brosaplanella commented 8 months ago

After attempting this, it was clear that it is not straightforward as PyBaMM does not support complex numbers yet. The alternative would be equally time consuming and not very robust so we decided to leave this issue for now.

An issue has been open in the PyBaMM repository about including complex numbers: https://github.com/pybamm-team/PyBaMM/issues/3766