paramm-team / pybamm-param

Parameter optimisation for PyBaMM.
BSD 3-Clause "New" or "Revised" License
38 stars 8 forks source link

Refactor optimisation result #71

Closed muhammedsogut closed 8 months ago

muhammedsogut commented 8 months ago

Description

This is slightly changing the presentation of results. Currently, they are presented in a list but this is now the best way as the user will struggle to understand which value is for which parameter. This PR will construct a dictionary with all the results including the standard deviation. Also, initial parameters can be accessed from result.

Fixes #10 #21

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

Key checklist

Further checks

muhammedsogut commented 8 months ago

@PipGrylls Could you have a look at test_optimisation_result.py? I refactor the result having a dictionary rather than a list. However, this has caused a problem on tests. I actually finished the PR, all of the example notebooks are working. I need your help to modify tests to get it passed. Thanks.