paramm-team / pybamm-param

Parameter optimisation for PyBaMM.
BSD 3-Clause "New" or "Revised" License
38 stars 8 forks source link

Reformat optimisation problem #9

Closed brosaplanella closed 2 years ago

brosaplanella commented 2 years ago

Description

Reformat optimisation problems and include OCP balance

Fixes #4

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

Key checklist:

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

codecov[bot] commented 2 years ago

Codecov Report

Merging #9 (321219c) into main (8fdb0cc) will increase coverage by 19.48%. The diff coverage is 63.63%.

@@             Coverage Diff             @@
##             main       #9       +/-   ##
===========================================
+ Coverage   57.74%   77.22%   +19.48%     
===========================================
  Files           6        8        +2     
  Lines         142      202       +60     
===========================================
+ Hits           82      156       +74     
+ Misses         60       46       -14     
Impacted Files Coverage Δ
pbparam/optimisation_problems/data_fit.py 54.54% <20.00%> (ø)
pbparam/optimisation_problems/OCP_balance.py 65.21% <65.21%> (ø)
pbparam/__init__.py 100.00% <100.00%> (ø)
...optimisation_problems/base_optimisation_problem.py 100.00% <100.00%> (ø)
pbparam/optimisation_result.py 100.00% <100.00%> (+58.33%) :arrow_up:
pbparam/optimisers/base_optimiser.py 100.00% <100.00%> (+5.88%) :arrow_up:
pbparam/optimisers/scipy_minimize.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

brosaplanella commented 2 years ago

Cool! Will merge tomorrow (will try to add a couple of tests to increase coverage).