search

paranext / paranext-core

Electron client, extension host, and C# library for Paranext
https://paranext.github.io/paranext-core/
MIT License
16 stars 2 forks source link

Newer P.B components do not have attribute 'Id' #1033

Open roopa0222 opened 1 month ago

roopa0222 commented 1 month ago

The new additions of P.B custom components do not have 'id' attribute. Please add 'Id' attribute for accessibility in testing.

  1. ChapterRangeSelector
  2. BookChapterControl
  3. DataTable
  4. ScriptureResultsViewer
  5. CharacterInventory
  6. HamburgerMenuButton
  7. MarkdownRenderer
  8. SearchBar
  9. ContextMenu
  10. DisableButton
  11. EnableButton
  12. FilterButton
  13. FilterDropdown
  14. InstallButton
  15. UpdateButton
Sebastian-ubs commented 1 month ago

possibly because Button is of type ReactNode, wheras e.g. DisableButton is of type Element

Sebastian-ubs commented 1 month ago

Please re-check. Some should have been fixed.

roopa0222 commented 1 month ago

Here is my update:

  1. ChapterRangeSelector - No Id
  2. BookChapterControl - No Id
  3. DataTable - No Id
  4. ScriptureResultsViewer - No Id
  5. CharacterInventory - Replaced with Inventory component - No Id
  6. HamburgerMenuButton - No Id
  7. MarkdownRenderer - Has Id
  8. SearchBar - No Id
  9. ContextMenu - No Id
  10. DisableButton - Yes Id
  11. EnableButton - Yes Id
  12. FilterButton - No Id
  13. FilterDropdown - Yes Id
  14. InstallButton - Yes Id
  15. UpdateButton - Yes Id

Most of the Buttons are updated. The composite P.B. components still need to be updated.

roopa0222 commented 2 weeks ago

NavigationContentSearch - No id SettingsList - No id