paranext / paranext-core

Electron client, extension host, and C# library for Paranext
https://paranext.github.io/paranext-core/
MIT License
17 stars 2 forks source link

Open Resource Viewer: OGRK issue #1064

Open GlennPruitt opened 2 months ago

GlennPruitt commented 2 months ago

I have installed OHEB and OGRK as resources in my Paratext 10 Studio projects folder. ("C:\Users\GPruitt.paratext-10-studio\projects\Paratext 9 Projects") Both resources are unzipped in their own subdirectories, OHEB and OGRK.

Problem 1) When I try to open the Resource Viewer I see this:

Image

From a user standpoint I think that the two resources should appear as one. The entry "OHEB/OGRK" is good, but then having OGRK by itself is not ideal.

Problem 2) If I then open the OHEB/OGRK resource in the viewer all is good provided I am looking at a Hebrew book - anything OT works good, but if I navigate to the New Testament then no text displays.

Problem 3) The corollary of problem 2. If I open the OGRK resource in the viewer and navigate to an OT book nothing displays.

Conceptually, OHEB and OGRK should act a s a single resource.

tjcouch-sil commented 2 months ago

We decided to work this if it is tiny. If it is much work, forget about it til after the demo.

Recommended action:

Smash OHEB and OGRK files together in one project

lyonsil commented 2 months ago

@GlennPruitt I think this combined project should work: https://drive.google.com/file/d/18Zlc3WQd9b8I5hZnsKfrz-jHTx6Ci4T3/view?usp=drive_link

lyonsil commented 2 months ago

From Glenn - the combined project works. We should still consider if we want to enable this in a more elegant way since the smashed together Settings.xml file isn't fully correct (e.g., there can only be one project language, but the USFM files are in two languages). However, for what we're trying to do for now this should be fine.

Sebastian-ubs commented 2 months ago

When I had done a similar combination previously, it was not loading because I was missing out <LanguageIsoCode> which seems to be required. After fixing that it worked with ```

8.0.63.1 11111111111111111111111111111111111111111111111111111111111111111100000000000000000000000000 65001 Galatia SIL 12 F Open Scriptures Hebrew Bible 2.1, UBS Greek New Testament 4th Edition F HEBGRK T F usfm.sty 4/10/2003 3:13:14 PM v 1 1.5 T F 000F2B0426E1457E8E496834AAA30FCE000000F1 ```