paranext / paranext-core

Electron client, extension host, and C# library for Paranext
https://paranext.github.io/paranext-core/
MIT License
17 stars 2 forks source link

Character Inventory results are not appropriate #1072

Open roopa0222 opened 3 months ago

roopa0222 commented 3 months ago

Describe the bug I opened zzz6 test project in Scripture Editor with Psalms on BCV. The Character Inventory results seem to be off. There are more characters (80) in the results in the Platform.Bible. Where as in the PT9 it generates only 74 characters.

To Reproduce

  1. Download zzz6 2021-08-16 project from the share drive. https://drive.google.com/file/d/1hLrDxduZXY2E7Q_zyo-_7OQrAw8gbXNK/view?usp=drive_link
  2. Extract it into the project folder location (C:\Users{profileName}.platform.bible\projects\Paratext 9 Projects) on P.B
  3. Open the project using the Scripture Editor menu item from P.B main menu
  4. Open the Character Inventory from the webview menus.
  5. Select the Psalms on BCV
  6. Select 'Current Book' on character inventory
  7. The results produced generate blank characters
  8. Click on the Psalm 0:0 changes BCV and opens a blank page in editor

Expected behavior The results should match the PT9 and Psalms 0:0 is not valid.

BlankCharacters_PB_zzz6

BlankCharacter_BlankScreen_PB_zzz6

CharacterInv_PT9_zzz6

roopa0222 commented 2 months ago

I retested it as part of https://github.com/paranext/paranext-core/issues/457

With the implementation of the scroll group on the BCV , Psalm 0:0 , throws an error. It prevents the Scripture Editor from opening a new blank page.

BCVError_Psalm00

However, we still have an issue with the mismatch of Characters displayed in PT95 and PB Repo Steps

  1. Open scripture editor with project zzz6 with BCV on Psalm 1:1
  2. Open the 'Inventory:Character' from the webview menu
  3. Verify the list of characters displayed . There is a mismatch between PT95 and PB
  4. Whitespace is considered in PB .

Expected outcome PT95 results and PB should match.

WhiteSpace_Character_PSA11

PT95_Character_PSA11

roopa0222 commented 1 month ago

PB is including the Characters from footnotes and verse characters (f,F,v, + \, N, r, t) Ex : Luke 1:1 [ \v 1 Wã dée\f + \fr 1.1 \ft BASE FN\f* ]