paranext / paranext-core

Electron client, extension host, and C# library for Paranext
https://paranext.github.io/paranext-core/
MIT License
14 stars 2 forks source link

Update BCV control for field user testing #860

Closed lyonsil closed 1 month ago

lyonsil commented 1 month ago

The UX team needs to be able to run this from Windows. Creating a build for them will be helpful. The testing will happen on April 27, so it would be important to have this done and verified working by the UX team by around April 25 at the latest.

Deliver to UX:

Pre-Rolf-Jolie-Fix Builds

- [x] Build with BCV selector only at top of app - https://github.com/paranext/paranext-core/actions/runs/8823680992 - [x] Build with BCV selector at top of app and on each tab - https://github.com/paranext/paranext-core/actions/runs/8823682333 - [x] Build with BCV selector only on each tab - https://github.com/paranext/paranext-core/actions/runs/8823684237

All the builds should:

Note to UX: there is now a "Lorem Ipsum" tab to imitate a text resource. If you do not see it or it gets closed, you'll have to close the application, delete the %APPDATA%\platform.bible\Local Storage (on Windows; varies on other OSes) folder, and start the application again. Note the layout will reset, so you will have to set up your layout again.

merchako commented 1 month ago

Package 1

Package 2

Package 3 (optional)

ianhewubs commented 1 month ago

Devs, when you feel confident about what's achievable on this task, please could you let us know you think will be implemented? What gets implemented will determine how we will write our test scripts.

(Also I don't know what "independent scroll" refers to in @merchako 's "package 1". Can anyone clarify?)

merchako commented 1 month ago

If there’s no scroll groups, we risk getting unuseful reactions from users. So when there are multiple tabs, should they use the same reference or be separate?

@mikelothers says most people will want to have synchronized scrolling. It only makes sense to sync scrolling if we have multiple resources.

tjcouch-sil commented 1 month ago

@paranext/paranext-ux the builds are now linked in the issue description! Let me know if you have any problems. At this point, I will likely only be able to respond to major issues that break the tests. image

ianhewubs commented 1 month ago

@tjcouch-sil Thanks for these, they look great.

There's just one behaviour which I think might be problematic enough to be worth fixing if you are able: The first time I click in the BCV control, it opens the dropdown with GEN at the top of the list (not with the current book and chapter in view). If I click away and then click back in the control, or if I press the down arrow on the keyboard, the current book and chapter appear located and selected, as expected.