Converting MUI based wrappers to Shadcn/ui

paranext / paranext-core

Electron client, extension host, and C# library for Paranext

https://paranext.github.io/paranext-core/

MIT License

14 stars 3 forks source link

Converting MUI based wrappers to Shadcn/ui #889

Open jolierabideau opened 1 month ago

jolierabideau commented 1 month ago

This ticket covers the effort to switch all platform-bible-react wrappers based on MUI to its Shadcn/ui equivalent.

Unchecked - not started In progress - development In review - PR Checked - merged into main

[x] Button to Shadcn Button
[ ] Checkbox to Shadcn Checkbox
[ ] Combobox to Shadcn Popover and Command (in progress)
[ ] IconButton to Shadcn Button with ability to add a lucide-react icon
[ ] Slider to Shadcn Slider
[ ] Snackbar to Shadcn Toast
[ ] Switch to Shadcn Switch
[x] TextField to Shadcn Input

jolierabideau commented 1 month ago

Here is a breakdown of the rest of the components in platform-bible-react

MenuItem and Toolbar are wrapped from MUI but do not have Shadcn/ui equivalents

ContextMenu and Table are not wrapped from MUI but do have Shadcn/ui equivalents.

The list below are custom components

ChapterRangeSelector
Checklist
GridMenu
GroupedMenuItemList
HamburgerMenuButton
RefSelector
SearchBar
TopLevelMenuComponent

tjcouch-sil commented 1 month ago

I found another interesting table library from shadcn - https://github.com/sadmann7/shadcn-table

However, I hesitate because it seems you might have to copy and paste a bunch of their code in specific places. I don't want to get stuck in a never-ending copypasta death spiral. I looked at this repo for about 20 seconds after seeing the name and description, but the 20 seconds seemed to indicate maybe it's not for us. Just thought I'd post here in case anyone wants to look at it and sees potential in it!

Sebastian-ubs commented 1 month ago

@rolfheij-sil is looking into tables