search

parapluu / encore

The Encore compiler.
BSD 3-Clause "New" or "Revised" License
43 stars 26 forks source link

Additional Savina Benchmarks #834

Closed supercooldave closed 7 years ago

supercooldave commented 7 years ago

This PR groups together Savina benchmarks that were previously submitted, but worked only for pre-Kappa. They have been fixed and now produce minimal output so they can be used in the stress test directory.

Credit should be given to Sophia, Einar and Tobias, who wrote these (but they also let them rot).

supercooldave commented 7 years ago

Interesting. The recent array fix has resulted in an assertion failure in NQueens. This could point to the bug Einar had trouble tracking down.

albertnetymk commented 7 years ago

The failure was there before the merge of array-fix, FYI.

supercooldave commented 7 years ago

@albertnetymk I knew the fix was related to arrays and the bug was related to arrays, so I put 2 and apple together and got yellow.

After looking in detail, the take away message is to every now and again run the compiler in debug mode to find more errors.

kikofernandez commented 7 years ago

what's the status on this? I see a commit that seems to fix the error. Let me know when this is fixed and I will review and merge this.

supercooldave commented 7 years ago

The bug in NQueens has been fixed. NQueens still has the problem that it leaks memory because the bulk of the computation occurs within a single recursive method call. Running it with input 17 almost killed my machine. I'm not sure whether it is a high priority to fix the problem. I tried to using forward, but that revealed bugs in forward.

supercooldave commented 7 years ago

In summary, just leave this open for a little longer. I'll see if I can find time to fix.