parasew / instiki

a basic wiki clone so pretty and easy to set up, you’ll wonder if it’s really a wiki.
https://golem.ph.utexas.edu/wiki/instiki/show/HomePage
503 stars 111 forks source link

textile autolinks do not work anymore #4

Open villem opened 15 years ago

villem commented 15 years ago

This probably maraoku related regression. With older releases the http://url and mailto@nowhere.com were automatically made proper html tags.

We have wiki starting from 0.7 releases so we cannot easily switch to different markup language.

distler commented 15 years ago

Autolinking was disabled in Revision 166 because the autolinking code sucked.

Anyone who wants to try fixing the code, so that it isn't as ridiculously slow, and is guaranteed not to produce ill-formed XHTML output, is welcome to do so. If they succeed, I'll re-enable auto-linking.

villem commented 15 years ago

Ok. Thanks for this pointer. We might enable this in our wiki. We do not use any advanced new features that has come since 0.7.

villem commented 15 years ago

You can close this one. It seems that comment and close is not working for me.

distler commented 15 years ago

Only Matthias or I can close issues.

As you have discovered, it's easy-enough to re-enable Autolinking-support. If this really does not cause any problems in the Textile formatter (it definitely causes problems with the Markdown formatter, and with the "advanced" new features), we might consider re-enabling it for Textile only.

Therefore, I think I will keep this issue open, as a reminder.

villem commented 15 years ago

I tried to re-enable the autolink code e.g just revert the commit http://github.com/parasew/instiki/commit/3a3cfeaa9b43a15e7cfbb90113465ab6f258e968. But this did not enable autolinking. Maybe I need to revert more?