search

paratestphp / paratest

:computer: Parallel testing for PHPUnit
MIT License
2.31k stars 228 forks source link

Add PHP 8.4 support #872

Closed joanhey closed 3 weeks ago

joanhey commented 2 months ago

The tests pass, but show deprecations with the symfony/string v5.4.0 class in PHP 8.4 lowest test.

Symfony/string is fixed https://github.com/symfony/string/commit/bce75043af265dc8aca536a6ab1d6b3181763529

~PD: perhaps it'll be better to change in composer.json :~

"require": {
        "php": "~8.2.0 || ~8.3.0 || ~8.4.0",

with

"require": {
        "php": ">=8.2",

Changed to "php": ">=8.2"

Fix #871 that break PestPHP https://github.com/pestphp/pest/issues/1199

Slamdunk commented 2 months ago

I don't like the CI build on 8.4 to be successful: https://github.com/paratestphp/paratest/actions/runs/10473712966/job/29006479710?pr=872#step:3:19

pcov is not yet compatible with 8.4, https://github.com/krakjoe/pcov/pull/111

Slamdunk commented 1 month ago

Apparently there's an infinite loop somewhere with PHP 8.4, but I can't debug it yet locally because the pcov PECL extension hasn't been updated yet, we need to wait

Slamdunk commented 3 weeks ago

Superseded by https://github.com/paratestphp/paratest/pull/898 thank you anyway for your contribution