search

paratestphp / paratest

:computer: Parallel testing for PHPUnit
MIT License
2.32k stars 229 forks source link

Update PHPUnit and add failOnPhpunitDeprecation option #883

Closed tvup closed 2 months ago

tvup commented 2 months ago

Update PHPUnit to 11.3.3: This PR updates the PHPUnit version to 11.3.3.

Synopsis: The parameters for PHPUnit\TextUI\ShellExitCodeCalculator::calculate have changed, including the addition of a boolean failOnPhpunitDeprecation.

Reference: PHPUnit commit.

Change:

Slamdunk commented 2 months ago

Thank you

nickygerritsen commented 2 months ago

Can this somehow be backported to 7.4 targeting PHPUnit 10.x? We are using 10.x and they also updated that, so we run into this issue.

Slamdunk commented 2 months ago

Yes, you can either:

  1. Cherry pick this patch and use it with https://github.com/cweagans/composer-patches
  2. Or sponsor me € 300 to release only this specific fix for the affected EOLed ParaTest's version
nickygerritsen commented 2 months ago

Thanks for the info. We will investigate what to do, since we can't update to PHPUnit 11 yet, because our dependencies require 10.x. Probably we will pin PHPUnit to 10.5.30 for now.

Slamdunk commented 2 months ago

Thanks with the support of @arnovbr, a fix has also been released in v7.4.6 for PHPUnit 10

AJenbo commented 2 months ago

It's a bit unfortunate that 7.4.6 requires PHP 8.2+ since the reason we use PHPUnit 10 in PHPMD and PDepend is that we support PHP 8.1+ (for the upcoming 3.0 releases). It would have been nice if Paratest's PHP requirement was the same as the PHPUnit versions it supports.

For our PHP 8.1 builds composer picks v7.3.1 + PHPUnit 10.5.33 and I don't see a way that we could set the constraints up to simultaneously take advantage of 7.4.6 and work on PHP 8.1.

pyrou commented 1 month ago

If you have to stay on phpunit 10.x or PHP 8.1, just stick to latest supported phpunit version, by requiring exact version:

composer require --dev phpunit/phpunit:10.5.31
AJenbo commented 1 month ago

Well yeah, but I would like fixes as we are doing long term support for the community. If push comes to shove well will either drop paratest or patch it, but community helping community would be nicer