paratestphp / paratest

:computer: Parallel testing for PHPUnit
MIT License
2.32k stars 229 forks source link

Keep support for PHPUnit 10 #887

Closed VincentLanglet closed 2 months ago

VincentLanglet commented 2 months ago

Hi @Slamdunk,

I don't think this PR (https://github.com/paratestphp/paratest/pull/860) require to drop the PHPUnit 10 support ; so i'd like to try working on keeping it. Paratest don't have to support every minor/patch of PHPUnit 10, just last ones. Which means that an issue with failOnPhpunitDeprecation won't exist on both PHPUnit 10 and 11.

Not all project can currently, easily, using PHPUnit 11 for the following reason:

I think it would be great for such a useful tool as paratest to keep both support of PHPUnit 10 and 11 for some time to help people migrating. I'm ok working on it. Currently I'm having errors locally, but since I have the same with phpunit 11 I dunno how is the state of PHPUnit 10 support with my branch, so I'd like to try on the CI.

Thanks.

Slamdunk commented 2 months ago

PHPUnit 10 has been supported until it was afforable, then https://github.com/paratestphp/paratest/issues/857 came and it wasn't anymore.

When available, the support of two different versions of PHPUnit is merely a fortunate coincidence that as soon as it disappears we can't have it anymore.

Slamdunk commented 2 months ago

Thanks with the support of @arnovbr, a fix has been released in v7.4.6