search

paratestphp / paratest

:computer: Parallel testing for PHPUnit
MIT License
2.32k stars 229 forks source link

Change `Options` constructor visibility to public #892

Closed HypeMC closed 1 month ago

HypeMC commented 1 month ago

I have a custom implementation of the RunnerInterface that decorates the default one, and I'd like to be able to modify some options in it. Currently, it's hard to instantiate a new Options object because the constructor is private, so I added a with method to help with that. I could also change the visibility of the constructor instead. I'd be ok with either approach, it'd just be nice to be able to do this.

Slamdunk commented 1 month ago

I'm OK with changing constructor visibility to public, go with it

HypeMC commented 1 month ago

I'm OK with changing constructor visibility to public, go with it

@Slamdunk Done :smile: