search

parautenbach / TeamCity-HipChat-Notifier

TeamCity HipChat Notifier for sending build server notifications to HipChat.
Other
59 stars 31 forks source link

0.5 does not list contributors any more #14

Closed pawelpabich closed 10 years ago

pawelpabich commented 10 years ago

Hi,

It looks like the refactoring broke the code responsible for list of contributors. Could you have a look?

Thanks

Pawel bug

parautenbach commented 10 years ago

Certainly, I'll look at it ASAP.

Just as an extra: Which VCS are you using?

And, does your TeamCity username match the VCS username, or do you have a mapping set under your TeamCity user settings? (It looks like your using AD integration.) One way to know whether this mapping is working is to check whether your changes are highlighted like in the screen shot. screen shot 2014-04-02 at 9 45 30 pm

The reason I'm asking is that I'm using the descriptive name (as opposed to just the name, which is optional to set in TeamCity, as you know), which will either return the full name or otherwise the username, but only if the username exists on TeamCity (according to Jetbrains when I asked them about this last time).

pawelpabich commented 10 years ago

Thanks.

  1. TFS
  2. My username and VCS username are different. My username is pawel.pabich and my VCS user name is company\pawel.pabich.
  3. Under TC I have username, name and email address specified. I would say this mapping does not work as TC displays company\pawel.pabich. Attached screenshot of my user settings. user

Let me know if you need anything else. I have TC setup locally so I can test fixes relatively quickly.

parautenbach commented 10 years ago

Ok, thanks. I think we're onto something.

Perhaps change your default VCS root username (as per your screen shot)? Alternatively, add company\pawel.pabich as a mapping for TFS.

Could your server admin also check whether a default domain is configured for your auth scheme (on TeamCity)?

When we can get TeamCity to correctly identify the VCS commit as being yours, I'm 99% certain the plugin will then work correctly too.

I could revert to my previous implementation, but I already knew then that it was just a hack (it will fail in other ways). I could potentially retrieve the user-to-VCS mapping and apply it myself, but that's kind of what the getCommitters call is supposed to do.

pawelpabich commented 10 years ago

I change my VCS name to company\pawel.pabich and now it works. Thanks a lot

parautenbach commented 10 years ago

Excellent, that's good news. You're welcome.