parautenbach / hass-shairport-sync

A custom media player for Home Assistant that allows you to control and get updates from a Shairport Sync installation using MQTT.
Apache License 2.0
69 stars 12 forks source link

Support GUI configuration and improve UI response #11

Closed mill1000 closed 1 year ago

mill1000 commented 1 year ago

This original goal of this PR was to implement a config flow to allow the integration to be configured via the GUI.

When configured via the GUI a new device with a media player entity is now created.

I got a bit out of hand and I overhauled a number of other things

parautenbach commented 1 year ago

This is awesome, @mill1000!

On the surface, this all looks good and is a nice catch-up on some Python (annotations) and HA updates. I've been thinking about implementing the config flow stuff, but I'm super short on time.

If you could also update the README to state which version you've tested with, I'd be happy to merge this. My own testing has just been against the one version I typically run.

My system using this is currently shut down, but I'll spin it up again soon (and probably upgrade everything on the Pi), which means I'll be in a better position to work on this project again and to test stuff.

For now, if we can just state which is the known version this was tested again, we're good to go (HA and Shairport Sync's versions).

mill1000 commented 1 year ago

@parautenbach, I think this is good to go now.

parautenbach commented 1 year ago

Muchas gracias!