search

paravoid / ircstream

MediaWiki RecentChanges → IRC gateway
Apache License 2.0
0 stars 1 forks source link

Bad PREFIX in RPL_ISUPPORT #2

Closed mmuehlenhoff closed 6 days ago

mmuehlenhoff commented 1 week ago

Another thing I noticed, also with Konversation as the IRC client, is that on start up it prints

XXX Server sent bad PREFIX in RPL_ISUPPORT, please report.

ircstream currently sends "PREFIX=", looking at https://datatracker.ietf.org/doc/html/draft-hardy-irc-isupport-00#section-4.15 if we want to specificy that no prefixes are allowed, we can simply keep omit it:

The value is OPTIONAL and when it is not specified indicates that no prefixes are supported.

I removed https://github.com/paravoid/ircstream/blob/main/ircstream/ircserver.py#L516 and that makes the error go away. And surprinsingly with that change (currently deployed on irc1003) the channel joining error from issue 1 also goes away.

mmuehlenhoff commented 1 week ago

(The test deploy on irc1003 has been reverted to plain 0.12.0 for better testability, so that the error shows again.