parca-dev / parca-agent

eBPF based always-on profiler auto-discovering targets in Kubernetes and systemd, zero code changes or restarts needed!
https://parca.dev/
Apache License 2.0
554 stars 68 forks source link

Support Nomad #1163

Open analytically opened 3 years ago

analytically commented 3 years ago

Would be great if it supported Nomad out of the box too - https://www.nomadproject.io/

brancz commented 3 years ago

Great idea! I don't know enough about Nomad to put this together, but if someone from the community wants to give this a go, I'd be more than happy to talk through an integration!

26tanishabanik commented 1 year ago

@brancz , I don't have any experience in Nomad but it is almost an alternative to Kubernetes and mostly integrates to other HashiCorp products like Terraform. Though, I don't have any experience in Nomad, I would like to work on it and explore more, if possible.

brancz commented 1 year ago

Ever since we introduced system-wide profiling in Parca Agent we are already profiling processes in Nomad as we just profile every process on a machine. What would be left to do though is attach metadata. I think we should first gather from Nomad users, what some useful metadata would be.

kakkoyun commented 1 year ago

I think this issue belongs to the agent side. If we add Nomad support, it should be another metadata service discovery implementation like Kubernetes and systemd. https://github.com/parca-dev/parca-agent/tree/main/pkg/discovery

Let's move it to the agent project if everyone agrees.

brancz commented 1 year ago

Agreed