parcel-bundler / lightningcss

An extremely fast CSS parser, transformer, bundler, and minifier written in Rust.
https://lightningcss.dev
Mozilla Public License 2.0
6.56k stars 190 forks source link

Bump browserslist-rs 0.16.0 #772

Closed chenjiahan closed 4 months ago

chenjiahan commented 4 months ago

Bump browserslist-rs 0.16.0, be consistent with Parcel and SWC:

Changes

chenjiahan commented 4 months ago

@mischnic I have fixed the CI, can you approve the workflow again? ❤️

mischnic commented 4 months ago

There's apparently still a failing test:

---- bundler::tests::test_bundle stdout ----
thread 'bundler::tests::test_bundle' panicked at src/bundler.rs:1121:5:
assertion `left == right` failed
  left: "@supports (foo: bar) or (color: red) {\n  .b {\n    color: green;\n  }\n}\n\n.a {\n  color: red;\n}\n"
 right: "@supports (color: red) or (foo: bar) {\n  .b {\n    color: green;\n  }\n}\n\n.a {\n  color: red;\n}\n"
stack backtrace:
   0:     0x5577d2c86156 - std::backtrace_rs::backtrace::libunwind::trace::hbee8a7973eeb6c93
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/../../backtrace/src/backtrace/libunwind.rs:104:5
   1:     0x5577d2c86156 - std::backtrace_rs::backtrace::trace_unsynchronized::hc8ac75eea3aa6899
                               at 
chenjiahan commented 4 months ago

I can not reproduce this failure in my device:

image

image

I'm not sure if this can be fixed by retry the CI, it would be great if you could help to confirm that.

mischnic commented 4 months ago

@devongovett Sounds like some nondeterministic map/list? I guess this really shouldn't happen?

devongovett commented 4 months ago

It's this, just haven't gotten around to fixing it https://github.com/parcel-bundler/lightningcss/issues/137