BenSapiens commented 6 years ago

🐛 bug report

So maybe I'm just retarded, but your bundler isn't actually deduplicating included assets.

🎛 Configuration (.babelrc, package.json, cli command)

Steps to reproduce:

Make two HTML files and two Javascript files.
Link the two Javascript files in the HTML files.
import TweenMax from "gsap"; in both Javascript files. (or react, or any other)
Build.

🤔 Expected Behavior

As stated here, "If an asset is required in more than one bundle, it is hoisted up to the nearest common ancestor in the bundle tree so it is not included more than once."

One of the resulting Javascript files should contain the TweenMax library and one shouldn't... right?

😯 Current Behavior

As it is, each imported library is built into each Javascript file. It will be downloaded again and again and again... every time anyone goes to a new page.

💁 Possible Solution

...I don't know, man.

🔦 Context

I'm just trying to use the spiffiest new build tool around.

💻 Code Sample

dist.tar.gz src.tar.gz

🌍 Your Environment

Software	Version(s)
Parcel	latest
Node	latest
npm/Yarn	latest
Operating System	MacOS 10.13.4

KeineLimonade commented 6 years ago

Just create a third file where you import both js files and import that one into your HTML with a script tag. That should produce the desired result

devongovett commented 6 years ago

in your scenario, the duplicated JS module does not have a common JS ancestor since it comes from two different HTML entries. therefore, we cannot hoist it up and dedup it. I believe this is working as designed.