parcel-pro-nl / magento2-module

Verzendmodule om gemakkelijk orders in te laden in het verzendsysteem van Parcel Pro.
https://support.parcelpro.nl/koppelingen/magento-handleiding
Open Software License 3.0
0 stars 8 forks source link

Address of selected pickup point not stored in order data #29

Open MatthijsvanNoort opened 5 months ago

MatthijsvanNoort commented 5 months ago

Using Firecheckout 1.31.1 magento/product-community-edition 2.4.6-p4 parcelpro/shipment 2.18.1

First i thought it was because Location picker generates error on popup close.

shipping-mixin.js:93 Uncaught TypeError: Cannot read properties of null (reading 'validateShippingInformation')
 at popup_close (shipping-mixin.js:93:22) at shipping-mixin.js:178:33

In vendor/parcelpro/shipment/view/frontend/web/js/view/shipping-mixin.js line 93

        function popup_close() {
            jQuery('#modal').hide();
            instance.validateShippingInformation();
        }

but the only instance mentioned in the js file is line 53 var instance = null;

So no wonder it generates this error...

Although i succeed in avoiding this js error, bottom line is: The Pickup Point Address is not saved in the order. I don't see it anywhere in backend or print labels.

I can see in previous orders that the shipment address was replaced by the pickup point's address. I came from an older version of the plugin, in which this part did work, but then the admin failed on 'Verzending aanmelden' & 'Print Label'.

last try, I noticed this line in requirejs mentioning FireCheckout, but adding that to requirejs didn't change a thing "Magento_Checkout/js/action/set-shipping-information":"Parcelpro_Shipment/js/action/set-shipping-information"