search

parcelvoy / platform

Parcelvoy: Open source multi-channel marketing automation platform. Send data-driven emails, sms, push notifications and more!
https://parcelvoy.com
MIT License
244 stars 42 forks source link

Fixes Message SQS DelaySeconds #481

Closed leobarcellos closed 3 months ago

leobarcellos commented 3 months ago

This fixes the Message SQS Queue Provider. "DelaySeconds" was being sent in milliseconds, however AWS SQS accepts seconds (and 900 is the maximum).

Screenshot of the error from worker below:

Screenshot 2024-08-01 at 16 35 47

pushchris commented 3 months ago

Appreciate the find! In general we've stopped using the SQS driver for queues because of how many odd restrictions it has and have considered removing it from the codebase before. If you are actively using it please let us know if you run into any other oddities!

leobarcellos commented 3 months ago

Appreciate the find! In general we've stopped using the SQS driver for queues because of how many odd restrictions it has and have considered removing it from the codebase before. If you are actively using it please let us know if you run into any other oddities!

Alright! I actually thought that with SQS it would be easier to scale and reduce the risk of "losing the message" if anything goes wrong. I thought that using redis might somehow lose it when scaling -- But it was just assumption.

I will keep monitoring and for sure report it if I run into any weirdness