parcio / julea

A Flexible Storage Framework for HPC
GNU Lesser General Public License v3.0
32 stars 30 forks source link

Copy file attributes in h5-migrate #171

Closed t-erxleben closed 1 year ago

t-erxleben commented 1 year ago

During tests on https://github.com/t-erxleben/julea/tree/hdf5-callbacks I noticed that attributes of files were not copied by the h5-migrate tool.

Iterating them separately fixes this.

Additionally I found that h5diff ignores objects that are only present in one file which is why I didn't notice the problem until now. Comparing the output of h5dump for both files should be safer for future CI tests.

michaelkuhn commented 1 year ago

Merged in 434db4d938bb32ef08cd40c48cf89de935b3425b. Thanks!