parcio / julea

A Flexible Storage Framework for HPC
GNU Lesser General Public License v3.0
33 stars 31 forks source link

Improve readability of execute functions #39

Closed ezickler closed 3 years ago

ezickler commented 5 years ago

This is just an idea to improve the readability and thus make it easy for new devs to understand the code.

I noticed that in jkv, jobject and jdistributed-object many but not all exec function have a repeated pattern of checking for local backend existence. It is check inconsistently either via != or ==. Doing this in a consistent way would make it easier to read and understand.

Here is an example: https://github.com/wr-hamburg/julea/blob/879b745059b41abd76fa816bd9458d49dcd89441/lib/object/jobject.c#L188-L228

michaelkuhn commented 3 years ago

The checks should be more consistent in b14074e63f2c0f164bcae6745e460fb9277f3455.