Configuration bug. "localhost" is always present when not included in configured host list.

pardahlman / RawRabbit

A modern .NET framework for communication over RabbitMq

MIT License

747 stars 144 forks source link

Configuration bug. "localhost" is always present when not included in configured host list. #260

Closed glenthomas closed 2 years ago

glenthomas commented 7 years ago

Description

When I provide a host name in my configuration, it does not replace the default host name "localhost", but adds it as a second host name. This causes all of my connections to be directed to localhost instead of my configured host.

Check List

[x ] All test passed.
[x ] Added documentation (if applicable).
[x ] Tests added to ensure functionality.
[x ] Pull Request to stable branch.

glenthomas commented 7 years ago

I have seen in another pull request you said that there are no plans for a new release of 1.x so will give 2.0 a try instead.

pardahlman commented 7 years ago

Thanks for the pull request. I will look at this in the coming days

glenthomas commented 7 years ago

Thanks @pardahlman. I think my PR may not be the ideal solution to the problem. It does not check to see if any hostnames have been configured before clearing the default localhost, but I am guessing there was an assumption that it would be overwritten anyway.