pardahlman / RawRabbit

A modern .NET framework for communication over RabbitMq
MIT License
746 stars 144 forks source link

Use SteelToe instead of Polly #311

Closed VenkateshSrini closed 6 years ago

VenkateshSrini commented 6 years ago

Hi,

Is it possible to use SteelToe (http://steeltoe.io) instead of Polly. I ask this because I want to use this on cloud foundry with .NET core. Please do let me know of the same

cocowalla commented 6 years ago

Polly handles transient-fault-handling (e.g. retries), whereas Steeltoe seems to be a large eco-system of cloud-related libraries. I guess you specifically meant Netflix Hystrix?

In any case, RawRabbit is very extensible, and only uses Polly in an optional RawRabbit.Enrichers.Polly package. I see no reason why you couldn't try to create your own plugin, using RawRabbit.Enrichers.Polly as a guide?

Disclaimer: Not the author, just a happy user trying to help out ;)

VenkateshSrini commented 6 years ago

Yes exactly. Also circuit breaker patterns are present in steel toe is well integrated with hystrix

On 06-Feb-2018 7:45 PM, "cocowalla" notifications@github.com wrote:

Polly handles transient-fault-handling (e.g. retries), whereas Steeltoe seems to be a large eco-system of cloud-related libraries. I guess you specifically meant Netflix Hystrix https://github.com/SteeltoeOSS/CircuitBreaker?

โ€” You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pardahlman/RawRabbit/issues/311#issuecomment-363434611, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHPMGDgu15W1_sWckgdSM7yV12bMQefks5tSF6PgaJpZM4R7EGj .

pardahlman commented 6 years ago

Hi @VenkateshSrini - thanks for reaching out. Also, thanks for answering @cocowalla - much appreciated! I'm not too familiar with steeltoe, but it is as cocowalla says - it shouldn't be difficult to integrate its mechanisms to RawRabbit - you can look at the Polly package for inspiration!

VenkateshSrini commented 6 years ago

@pardahlman , I know polly and have also worked with it in many projects. I have no complaints against polly. The only ask if you could also probably add an "Use" method to steelToe it will be useful. At present their circuit breaker is well integrated with Eureka spring cloud services and provides the very much needed dash board. Otherwise give the steps to include the steel toe so that I will try out the same

pardahlman commented 6 years ago

Understood. Unfortunately, I'm very busy at the moment, but if you have knowledge in steel toe, perhaps you could look into integrating it with RawRabbit? ๐Ÿ˜„

VenkateshSrini commented 6 years ago

Definitely based on my bandwidth o will try it

On 07-Feb-2018 9:10 PM, "Pรคr Dahlman" notifications@github.com wrote:

Understood. Unfortunately, I'm very busy at the moment, but if you have knowledge in steel toe, perhaps you could look into integrating it with RawRabbit? ๐Ÿ˜„

โ€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pardahlman/RawRabbit/issues/311#issuecomment-363808727, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHPMFOY12sjdp6j8pgPOwqw7FpJCm2Xks5tScPvgaJpZM4R7EGj .

pardahlman commented 6 years ago

Hi @VenkateshSrini - I'm closing this ticket for now. Feel free to reopen or reference it if you get around to create a PR. Thanks!