Fixing : Get request on empty queue throws a null exception

[Ankurkh1]

Description

Fixing : Get request on empty queue throws a null exception fix #323

Fixing : Get Operation causing "ChannelAllocationException: The connection cannot support any more channels. Consider creating a new connection"

fix #325

Check List

• [ ] All test passed.
• [ ] Added documentation (if applicable).
• [ X] Tests added to ensure functionality.
• [ ] Pull Request to stable branch.

[pardahlman]

Thanks @Ankurkh1 - I'll give this a closer look in a few days! 👏

[pardahlman]

Excellent work! Thanks @Ankurkh1 👌

[pardahlman]

Ah @Ankurkh1 - it just dawned on my why this operation didn't use the channel pool: The channel is closed as the consumer disposes the Ackable<TMessage> like so

using(var ackable = await client.GetManyAsync<BasicMessage>(3))
{
  foreach (var message in ackable.Content)
  {
    if (TryDoWork(message))
    {
      message.Ack();
    }
    else
    {
      message.Nack();
    }
  }
}

(You could also dispose the ackable explicitly ackable.Dispose(). It feels a bit dangerous to close channels in the default channel pool as the ackable is GC'ed, so I'll revert the fix so that the method creates its own channels. I believe that the problems you had could be eliminated by following the pattern above.

[Ankurkh1]

Thanks for the Reply @pardahlman. I tried what you have suggested here and I am sorry to report, the problem still persist. I am using message.Dispose() and a later stage and in watch window I can see the channel marked as closed with reply test "Good bye" but, on server side the channel count on the connection reached 65535. I am not savvy enough with RabbitMQ to know what is going on. Is it a requirement to call explicit close on the channel?

Like always, any help would be greatly appreciated!!