search

pardahlman / RawRabbit

A modern .NET framework for communication over RabbitMq
MIT License
746 stars 144 forks source link

Ensure the consumer cache gets flushed of cancelled and faulted tasks #421

Open alexdawes opened 2 years ago

alexdawes commented 2 years ago

Description

Currently, the _consumerCache within the ConsumerFactory has bad IBasicConsumer's removed and swapped out for new ones. This mechanism uses the Task.IsCompleted method (https://docs.microsoft.com/en-us/dotnet/api/system.threading.tasks.task.iscompleted?view=net-6.0), which catches cancelled and faulted tasks as well. However, if the task is faulted/cancelled, then calling Task.Result on such a task will result in the error (or TaskCanceledException) to be thrown.

Because of this, if the task in the cache becomes cancelled or faulted for whatever reason (I experienced this myself with a cancelled task, though have no idea where it came from) then the error will remain in the cache and be thrown whenever the consumer for that key is retreived again

This PR is a simple change to the logic to treat faulted and cancelled tasks separately to successfully completed tasks.

VladProkopovich commented 2 years ago

@pardahlman Can you please take a look?