pardeike / RimGPT

Let ChatGPT throw shade on your gameplay. Needs two license keys: ChatGPT + Azure (for TTS)
MIT License
41 stars 13 forks source link

Added Awareness, Primary/SEcondary model switching #8

Closed MattMcFarland closed 9 months ago

MattMcFarland commented 9 months ago

RimGPT now aware of:

MattMcFarland commented 9 months ago

This is a quick review. I get the feeling that the new changes can add some burden to a heavy game and we might need to invent some mechanism that spreads out the cpu load over time. Beside that (and my nitpicking on code style) this is an interesting change although I thought that the use of two models was a bit more clever. Nevertheless a good PR

Yeah I share the concern about the cpu load over time. I'm definitely open to spreading this out. I also think it might be good to add some settings that allow the player to turn off/on some of the patches.

As for nitpicking on code style, totally ok with me - I get it :) I've done my fair share.

As for model switching, I'd love to explore a better method. My main concern was over cost savings, but to your point there's a lot more worth exploring here.