search

pardom-zz / CleanNews

Hacker News client written with Clean Architecture and Redux
94 stars 13 forks source link

Consider Changing Your Package Structure #37

Open christopherperry opened 6 years ago

christopherperry commented 6 years ago

From Bob's Screaming Architecture post:

screen shot 2017-10-15 at 7 56 44 pm

I poked into your example here and it didn't scream "Clean News!" to me. Consider packaging by feature and doing Clean in one vertical slice at that level.

Aditya94A commented 6 years ago

I was just admiring the data module's structure and then I saw

screenshot 2017-12-16 18 16 04

Yikes!

Clean architecture and packaging by "type" rather than "feature" don't really fit together :)