parinfer / parinfer.js

Let's simplify the way we write Lisp
https://shaunlebron.github.io/parinfer
MIT License
1.75k stars 40 forks source link

Parinfer Parens Mode bug #187

Closed NightMachinery closed 1 year ago

NightMachinery commented 6 years ago
-               ("map" . 8614           ; ↦
-                (push pretty-symbol prettify-symbols-alist))))))
+               ("map" . 8614)           ; ↦
+               )) (push pretty-symbol prettify-symbols-alist)))

The - parts are parinfer's doing. You can take a look at the complete diff log I posted at https://github.com/syl20bnr/spacemacs/issues/10648 . Another prominent example is that parinfer moves comments out of sexps:

   (lispyville-set-key-theme
    '(operators
      c-w
-     (escape insert)))
-  ;; (additional-movement normal visual motion)
-  
+     (escape insert)
+     ;; (additional-movement normal visual motion)
+     ))
shaunlebron commented 6 years ago

thanks! Can you paste your file into this page below to see if it's really a problem with core, or just the spacemacs plugin?

https://beta.observablehq.com/@shaunlebron/parinfer-test

colonelrascals commented 6 years ago

@shaunlebron @NightMachinary I've run both examples through the parinfer test, and it does seem that parenMode moves comments out of sexps.

Screen shot is attached.

parenmode
colonelrascals commented 6 years ago

Possibly ignore closing the paren until the comment is escaped?

shaunlebron commented 6 years ago

Right, this is the major issue tracked in #92, and have been slumbering on implementation in #175

P.S. Observable ❤️ 💯

shaunlebron commented 1 year ago

Closing as a duplicate of #92