search

paris-saclay-cds / ramp-workflow

Toolkit for building predictive workflows on top of pydata (pandas, scikit-learn, pytorch, keras, etc.).
https://paris-saclay-cds.github.io/ramp-docs/
BSD 3-Clause "New" or "Revised" License
68 stars 42 forks source link

BUG: blending detection predictions with zero confidence #109

Closed jorisvandenbossche closed 6 years ago

jorisvandenbossche commented 6 years ago

Ugly hack, but I think should solve the problem. Ideally predictions with zero confidence are discarded in an earlier step, but I think it is rather costly the go through all predictions just to do that.

codecov[bot] commented 6 years ago

Codecov Report

Merging #109 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage    86.9%   86.94%   +0.04%     
==========================================
  Files          70       70              
  Lines        2581     2589       +8     
==========================================
+ Hits         2243     2251       +8     
  Misses        338      338
Impacted Files Coverage Δ
rampwf/prediction_types/detection.py 84.31% <100%> (+0.31%) :arrow_up:
...ediction_types/tests/test_detection_predictions.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03bea41...7eab6b9. Read the comment docs.