search

paris-saclay-cds / ramp-workflow

Toolkit for building predictive workflows on top of pydata (pandas, scikit-learn, pytorch, keras, etc.).
https://paris-saclay-cds.github.io/ramp-docs/
BSD 3-Clause "New" or "Revised" License
68 stars 42 forks source link

[MRG] MAINT vendor colored and tabulate #138

Closed glemaitre closed 6 years ago

glemaitre commented 6 years ago

@mehdidc @jorisvandenbossche @aboucaud @kegl @agramfort It is what I thought about vendoring.

agramfort commented 6 years ago

I am not the BDFL of the this repo but I have no objection. Provided travis is green ;)

aboucaud commented 6 years ago

No objection either, this looks pretty clean this way.

However,@glemaitre, if you want to preserve the exact content of tabulate and colored, you should exclude the externals dir from the flake8 linting ; otherwise travis will complain, and @agramfort will be unhappy..again.

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@00a6ff3). Click here to learn what that means. The diff coverage is 10.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #138   +/-   ##
=========================================
  Coverage          ?   79.73%           
=========================================
  Files             ?      109           
  Lines             ?     3746           
  Branches          ?        0           
=========================================
  Hits              ?     2987           
  Misses            ?      759           
  Partials          ?        0
Impacted Files Coverage Δ
rampwf/externals/tabulate.py 0% <0%> (ø)
rampwf/externals/colored/colors.py 100% <100%> (ø)
rampwf/externals/colored/back.py 100% <100%> (ø)
rampwf/__init__.py 100% <100%> (ø)
rampwf/externals/colored/__init__.py 100% <100%> (ø)
rampwf/utils/pretty_print.py 94.87% <100%> (ø)
rampwf/externals/colored/style.py 100% <100%> (ø)
rampwf/externals/colored/fore.py 100% <100%> (ø)
rampwf/externals/colored/hex.py 40% <40%> (ø)
rampwf/externals/colored/colored.py 60% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00a6ff3...c267c9c. Read the comment docs.

glemaitre commented 6 years ago

@aboucaud I fix the flake8 as you mentioned