search

paris-saclay-cds / ramp-workflow

Toolkit for building predictive workflows on top of pydata (pandas, scikit-learn, pytorch, keras, etc.).
https://paris-saclay-cds.github.io/ramp-docs/
BSD 3-Clause "New" or "Revised" License
68 stars 43 forks source link

FIX failing test #206

Closed lucyleeow closed 4 years ago

lucyleeow commented 4 years ago

205

codecov[bot] commented 4 years ago

Codecov Report

Merging #206 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #206   +/-   ##
=======================================
  Coverage   81.01%   81.01%           
=======================================
  Files         118      118           
  Lines        4641     4641           
=======================================
  Hits         3760     3760           
  Misses        881      881

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1b4273...f50bf08. Read the comment docs.

lucyleeow commented 4 years ago

Looking at the tensorflow system requirements, it seems a newer version of pip is require than what we are using:

$ pip --version

pip 9.0.1 from /home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages (python 3.6)

I'll update the .travis.yml file to to update pip, unless there are objections?

lucyleeow commented 4 years ago

@agramfort will the underlying problem for the fail on tensorflow > 2.0.0 need to be addressed though?

agramfort commented 4 years ago

it's a packaging tensorflow issue I would say.

lucyleeow commented 4 years ago

I'll merge then.