paris-saclay-cds / ramp-workflow

Toolkit for building predictive workflows on top of pydata (pandas, scikit-learn, pytorch, keras, etc.).

https://paris-saclay-cds.github.io/ramp-docs/

BSD 3-Clause "New" or "Revised" License

68 stars 42 forks source link

colored output only form terminals that know how to handle it #225

Closed kegl closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #225 into master will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   81.61%   81.62%   +0.01%     
==========================================
  Files         130      130              
  Lines        4863     4866       +3     
==========================================
+ Hits         3969     3972       +3     
  Misses        894      894

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e90e3e7...f8bbce8. Read the comment docs.

albertcthomas commented 4 years ago

I will test it on both cmder and anaconda prompt and let you know.

agramfort commented 4 years ago

ok let's try this. We can adjust when we see people hitting the issue. If it fixes issue for you, me, guillaume and windows users using anaconda prompt it's already great !

kegl commented 4 years ago

OK, @agramfort pls merge if you're happy. The AppVeyor failure seems unrelated.

agramfort commented 4 years ago

works on my mac.

can someone else test? @albertcthomas does it work for you on windows wtih cmdr and anaconda prompt?

albertcthomas commented 4 years ago

With last commit, same as before:

This is working for me in cmder (with colors) and in command prompt/anaconda prompt/power shell (without colors).

agramfort commented 4 years ago

great

let's wait for @glemaitre to test before we merge.

glemaitre commented 4 years ago

Working in Linux. The failure is due to a missing wheel of scikit-learn for Python 3.5 (then we try to install from source which is not intended. We should probably update the support of ramp-workflow for 3.6/3.7 (not 3.8 because of tensorflow)

agramfort commented 4 years ago

ok green. Thanks @kegl for the fix and @albertcthomas @glemaitre for testing !