I think that navigating and debugging the code could be made easier if there were different filenames for the workflow and the submission (for instance classifier.py is both a workflow module and most of the time the module of the submission) as well as different names for the workflow objects and the submission objects.
For instance, for the classifier workflow the name used for the workflow object Classifier with train_submission and test_submission methods is the same as the Classifier object with fit and predict of the submission. This is of course even more relevant when we use workflows such as FeatureExtratorClassifier where we have a line with
A solution would be to use classifier_workflow.py instead of classifier.py and ClassifierWorkflow for the workflow object and keep Classifer for the submission. The former might be a bit redundant and less justified if we consider only the rampwf codebase alone without a kit but the latter seems relevant as the classifier workflow object Classifier is called in FeatureExtractorClassifier and the Classifier object of the submission is called in the Classifier workflow. We could instead have
I think that navigating and debugging the code could be made easier if there were different filenames for the workflow and the submission (for instance
classifier.py
is both a workflow module and most of the time the module of the submission) as well as different names for the workflow objects and the submission objects.For instance, for the classifier workflow the name used for the workflow object
Classifier
withtrain_submission
andtest_submission
methods is the same as theClassifier
object withfit
andpredict
of the submission. This is of course even more relevant when we use workflows such asFeatureExtratorClassifier
where we have a line withA solution would be to use
classifier_workflow.py
instead ofclassifier.py
andClassifierWorkflow
for the workflow object and keepClassifer
for the submission. The former might be a bit redundant and less justified if we consider only the rampwf codebase alone without a kit but the latter seems relevant as the classifier workflow objectClassifier
is called inFeatureExtractorClassifier
and theClassifier
object of the submission is called in theClassifier
workflow. We could instead have