search

paris-saclay-cds / ramp-workflow

Toolkit for building predictive workflows on top of pydata (pandas, scikit-learn, pytorch, keras, etc.).
https://paris-saclay-cds.github.io/ramp-docs/
BSD 3-Clause "New" or "Revised" License
68 stars 43 forks source link

FIX encoding for new nbconvert version #252

Closed albertcthomas closed 3 years ago

albertcthomas commented 3 years ago

Appveyor is red now that nbconvert is installed with a version higher than 6. It was green when using a version < 6.

Trying to fix it by forcing utf8 encoding when reading the notebook. Note that the notebook is written to a file with an utf8 encoding (https://github.com/paris-saclay-cds/ramp-workflow/blob/master/rampwf/utils/notebook.py#L59)

codecov[bot] commented 3 years ago

Codecov Report

Merging #252 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         133      133           
  Lines        4921     4921           
=======================================
  Hits         4023     4023           
  Misses        898      898
Impacted Files Coverage Δ
rampwf/utils/notebook.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1c78ea...98d9ba8. Read the comment docs.

agramfort commented 3 years ago

thx @albertcthomas