search

paris-saclay-cds / ramp-workflow

Toolkit for building predictive workflows on top of pydata (pandas, scikit-learn, pytorch, keras, etc.).
https://paris-saclay-cds.github.io/ramp-docs/
BSD 3-Clause "New" or "Revised" License
68 stars 43 forks source link

Fixing CI #262

Closed albertcthomas closed 3 years ago

albertcthomas commented 3 years ago

~First trying with scikit-learn < 0.24 before investigating a bit more.~

codecov[bot] commented 3 years ago

Codecov Report

Merging #262 (cf37efe) into master (67a26b3) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         133      133           
  Lines        4921     4921           
=======================================
  Hits         4023     4023           
  Misses        898      898

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67a26b3...cf37efe. Read the comment docs.

albertcthomas commented 3 years ago

The failure can be fixed by upgrading to ubuntu xenial (16.04), see for instance here for a related issue. As Xenial is now the min-dependency assumed for scikit-learn this might be a good enough fix here... WDYT @agramfort?

agramfort commented 3 years ago

Thx @albertcthomas