search

paris-saclay-cds / ramp-workflow

Toolkit for building predictive workflows on top of pydata (pandas, scikit-learn, pytorch, keras, etc.).
https://paris-saclay-cds.github.io/ramp-docs/
BSD 3-Clause "New" or "Revised" License
68 stars 43 forks source link

MAINT/Fix security vulnerability warning by updating to tensorflow 2.0.4 #266

Closed rth closed 3 years ago

rth commented 3 years ago

Fixes Github security warnings on the home page (and in email reminders). Tensorflow can probably be updated to a later version as well but I'm not fully sure about the implications and for now I just want to remove the warnings.

codecov[bot] commented 3 years ago

Codecov Report

Merging #266 (50455e3) into master (e97a272) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   82.13%   82.13%           
=======================================
  Files         133      133           
  Lines        4938     4938           
=======================================
  Hits         4056     4056           
  Misses        882      882

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e97a272...50455e3. Read the comment docs.

rth commented 3 years ago

Hmm, it looks like this update makes drug_spectra training fail on Python 3.6 only.

agramfort commented 3 years ago

bump drug_spectra to 3.7?

rth commented 3 years ago

No actually, drug_spectra test is just flaky including on master. Re-starting the CI fixed it. We need to address that but it's not related to this PR.