Closed rth closed 3 years ago
Merging #268 (8c57d73) into master (f8fdf98) will increase coverage by
0.20%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #268 +/- ##
==========================================
+ Coverage 82.13% 82.34% +0.20%
==========================================
Files 133 136 +3
Lines 4938 4995 +57
==========================================
+ Hits 4056 4113 +57
Misses 882 882
Impacted Files | Coverage Δ | |
---|---|---|
rampwf/hyperopt/hyperopt.py | 98.63% <100.00%> (+0.01%) |
:arrow_up: |
rampwf/hyperopt/tests/test_hyperparameter.py | 100.00% <100.00%> (ø) |
|
rampwf/tests/kits/iris_data_label/problem.py | 100.00% <100.00%> (ø) |
|
...label/submissions/random_forest_10_10/estimator.py | 100.00% <100.00%> (ø) |
|
...s_data_label/submissions/starting_kit/estimator.py | 100.00% <100.00%> (ø) |
|
rampwf/tests/test_kits.py | 96.15% <100.00%> (+0.59%) |
:arrow_up: |
rampwf/utils/cli/testing.py | 62.50% <100.00%> (+0.96%) |
:arrow_up: |
rampwf/utils/testing.py | 100.00% <100.00%> (ø) |
|
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f8fdf98...8c57d73. Read the comment docs.
also we should have a changelog / what's new page to document changes
Indeed updated the changelog in https://github.com/paris-saclay-cds/ramp-workflow/pull/265, I was thinking to merge that one first to avoid to deal with merge conflicts here.
ok fair enough... merge when happy
Thanks @rth and @agramfort
This aims to add to master 2 PRs from advanced branch that I think should be fairly safe to include in 0.4.0 (#264 )
For the other more major PRs in advanced, I think it would be better to include them for 0.5.0 .
Will merge this without squashing to preserve history and attributions.