Closed rth closed 3 years ago
Merging #271 (6102a34) into master (fbedf04) will increase coverage by
0.24%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 82.34% 82.58% +0.24%
==========================================
Files 136 138 +2
Lines 4995 5059 +64
==========================================
+ Hits 4113 4178 +65
+ Misses 882 881 -1
Impacted Files | Coverage Δ | |
---|---|---|
rampwf/prediction_types/base.py | 87.09% <100.00%> (+0.88%) |
:arrow_up: |
rampwf/prediction_types/clustering.py | 95.23% <100.00%> (+6.34%) |
:arrow_up: |
rampwf/prediction_types/combined.py | 97.72% <100.00%> (+0.42%) |
:arrow_up: |
rampwf/prediction_types/detection.py | 85.18% <100.00%> (+0.56%) |
:arrow_up: |
rampwf/prediction_types/multiclass.py | 95.55% <100.00%> (+0.43%) |
:arrow_up: |
rampwf/prediction_types/regression.py | 95.45% <100.00%> (+1.01%) |
:arrow_up: |
rampwf/score_types/base.py | 69.23% <100.00%> (-4.11%) |
:arrow_down: |
rampwf/score_types/brier_score.py | 100.00% <100.00%> (ø) |
|
rampwf/score_types/classifier_base.py | 100.00% <100.00%> (ø) |
|
rampwf/score_types/combined.py | 91.66% <100.00%> (ø) |
|
... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fbedf04...6102a34. Read the comment docs.
I think the first 2 commits (the one different to Decoupled CV) are already on master and not needed in this PR. I don't think they appear in the diff so maybe it's not a big deal.
I also think that we could use this opportunity to remove the co-authoring of the decoupled CV? @kegl used 2 usernames.
I don't think they appear in the diff so maybe it's not a big deal.
yes they don't appear in the changes.
I also think that we could use this opportunity to remove the co-authoring of the decoupled CV
Thanks for checking @albertcthomas ! I removed it and the 2 extra commits.
This is a backport of https://github.com/paris-saclay-cds/ramp-workflow/pull/243 to master.
I'll mention https://github.com/paris-saclay-cds/ramp-board/pull/515 in the test protocol documentation which should allow running ramp-board CI on arbitrary ramp-workflow PRs using manual triggers