Closed albertcthomas closed 2 years ago
Ping @agramfort and @rth , if someone would like to review from the Saclay side. It went through internal review on ours, @albertcthomas will comment tomorrow. The two reasons we decided to do this:
Travis is missing because of the migration from travis-ci.org to travis-ci.com. I don't think I have the rights to add the repo to travis-ci.com.
Should we just migrate to GH Actions? Those are enabled by default, and the CI setup is fairly straightforward in this repo.
Should we just migrate to GH Actions? Those are enabled by default, and the CI setup is fairly straightforward in this repo.
This might be better indeed.
Should we just migrate to GH Actions? Those are enabled by default, and the CI setup is fairly straightforward in this repo. Would be great!
Could you please merge master in to enable CI?
Merging #287 (3cfd1fc) into master (aee6274) will increase coverage by
0.15%
. The diff coverage is94.56%
.
@@ Coverage Diff @@
## master #287 +/- ##
==========================================
+ Coverage 82.97% 83.12% +0.15%
==========================================
Files 137 137
Lines 4680 4736 +56
==========================================
+ Hits 3883 3937 +54
- Misses 797 799 +2
Impacted Files | Coverage Δ | |
---|---|---|
..._old/submissions/starting_kit/feature_extractor.py | 100.00% <ø> (ø) |
|
rampwf/utils/testing.py | 100.00% <ø> (ø) |
|
rampwf/utils/submission.py | 87.56% <86.48%> (+0.29%) |
:arrow_up: |
...ssengers_old/submissions/starting_kit/regressor.py | 100.00% <100.00%> (ø) |
|
...titanic_old/submissions/starting_kit/classifier.py | 100.00% <100.00%> (ø) |
|
rampwf/tests/test_kits.py | 97.10% <100.00%> (+0.08%) |
:arrow_up: |
rampwf/utils/__init__.py | 100.00% <100.00%> (ø) |
|
rampwf/utils/cli/testing.py | 63.41% <100.00%> (+0.91%) |
:arrow_up: |
rampwf/utils/tests/test_submission.py | 100.00% <100.00%> (ø) |
|
rampwf/workflows/classifier.py | 100.00% <100.00%> (ø) |
|
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update aee6274...3cfd1fc. Read the comment docs.
@agramfort if no objections from the Saclay side, we'll merge this next week.
On behalf of @kegl
This PR adds the possibility of partial training to the workflow by loading a previous pickled model
--partial-train