search

paris-saclay-cds / ramp-workflow

Toolkit for building predictive workflows on top of pydata (pandas, scikit-learn, pytorch, keras, etc.).
https://paris-saclay-cds.github.io/ramp-docs/
BSD 3-Clause "New" or "Revised" License
68 stars 43 forks source link

DOC Typos found by codespell #289

Closed DimitriPapadopoulos closed 2 years ago

DimitriPapadopoulos commented 2 years ago

Add codespell configuration in setup.cfg.

DimitriPapadopoulos commented 2 years ago

Should I add a spellcheck target to the Makefile?

It could even be a manual pre-commit hook.

agramfort commented 2 years ago

+1 for a convenient spellcheck target in makefile

DimitriPapadopoulos commented 2 years ago

Added the spellcheck target - should it be the more generic spellcheck or codespell?

DimitriPapadopoulos commented 2 years ago

Ah, I could also add 'spellcheck': ['codespell'] to EXTRAS_REQUIRE: https://github.com/paris-saclay-cds/ramp-workflow/blob/7d075219d42cf5c8cca62c6c9804dba8c04907cc/setup.py#L40-L43

rth commented 2 years ago

Thanks @DimitriPapadopoulos . I think the current version is sufficient. Would you be interested in also doing this on the ramp-board repo?

rth commented 2 years ago

OK, because GH Actions were not run here, it actually broke flake8 on master. Will try to fix it soon, unless someone does it before.