paris-saclay-cds / ramp-workflow

Toolkit for building predictive workflows on top of pydata (pandas, scikit-learn, pytorch, keras, etc.).
https://paris-saclay-cds.github.io/ramp-docs/
BSD 3-Clause "New" or "Revised" License
68 stars 42 forks source link

[MRG + 1] Use versioneer for version management #87

Closed jorisvandenbossche closed 7 years ago

jorisvandenbossche commented 7 years ago

This currently gives:

In [1]: import rampwf

In [2]: rampwf.__version__
Out[2]: 'v0.1.0+16.g28f84af'
jorisvandenbossche commented 7 years ago

Note: all those files are automatically generated and should never be adapted by hand (otherwise it would be a lot of code to maintain that this adds ..)

kegl commented 7 years ago

Travis fails

Processing /home/travis/build/paris-saclay-cds/ramp-workflow
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-gCmmfo-build/setup.py", line 28, in <module>
        VERSION = version
    NameError: name 'version' is not defined

otherwise LGTM.

codecov[bot] commented 7 years ago

Codecov Report

Merging #87 into master will decrease coverage by 5.47%. The diff coverage is 45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   89.41%   83.93%   -5.48%     
==========================================
  Files          66       67       +1     
  Lines        1993     2272     +279     
==========================================
+ Hits         1782     1907     +125     
- Misses        211      365     +154
Impacted Files Coverage Δ
rampwf/__init__.py 100% <100%> (ø) :arrow_up:
rampwf/_version.py 44.4% <44.4%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d70cff5...37692a3. Read the comment docs.

jorisvandenbossche commented 7 years ago

Whoops, fixed that

glemaitre commented 7 years ago

LGTM